Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CertificateAuthorityActivation customSetDefaults method #55

Merged

Conversation

ndbhat
Copy link
Contributor

@ndbhat ndbhat commented Jun 28, 2024

Description of changes:

  1. Set fields of a to the fields of b in customSetDefaults method

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and anbaig June 28, 2024 15:07
@ack-prow ack-prow bot added the approved label Jun 28, 2024
@ndbhat ndbhat changed the title Update CertificateAuthorityActivation customSetDefaults Update CertificateAuthorityActivation customSetDefaults method Jun 28, 2024
Copy link

ack-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anbaig, ndbhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anbaig anbaig added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@ack-prow ack-prow bot merged commit a3947c3 into aws-controllers-k8s:main Jul 8, 2024
6 checks passed
if ackcompare.IsNil(a.ko.Spec.Status) && ackcompare.IsNotNil(b.ko.Spec.Status) {
a.ko.Spec.Status = defaultStatus
a.ko.Spec.Status = b.ko.Spec.Status
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tests needed here? @ndbhat @anbaig

@ndbhat ndbhat deleted the ca-activation-custom-set-defaults branch July 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants